Skip to content

Conversation

@GWSzeto
Copy link
Contributor

@GWSzeto GWSzeto commented Oct 16, 2024

Problem solved

Short description of the bug fixed or feature added


PR-Codex overview

This PR focuses on enhancing the ModuleCard component and its integration within the InstalledModulesTable, improving the user interface and functionality for managing modules in a dashboard.

Detailed summary

  • Added a new Storybook entry for ModuleCard with desktop and mobile views.
  • Implemented useMutation for uninstalling and updating modules in ModuleCard.
  • Replaced table structure in InstalledModulesTable with a flexbox layout using ModuleCard.
  • Removed unused components and code related to table rendering.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@changeset-bot
Copy link

changeset-bot bot commented Oct 16, 2024

⚠️ No Changeset found

Latest commit: 7aab5ca

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel
Copy link

vercel bot commented Oct 16, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 28, 2024 2:31pm
3 Skipped Deployments
Name Status Preview Comments Updated (UTC)
docs-v2 ⬜️ Skipped (Inspect) Oct 28, 2024 2:31pm
thirdweb_playground ⬜️ Skipped (Inspect) Oct 28, 2024 2:31pm
wallet-ui ⬜️ Skipped (Inspect) Oct 28, 2024 2:31pm

@graphite-app
Copy link
Contributor

graphite-app bot commented Oct 16, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

@github-actions
Copy link
Contributor

github-actions bot commented Oct 16, 2024

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 42.9 KB (0%) 859 ms (0%) 2.5 s (-51.24% 🔽) 3.3 s
thirdweb (cjs) 102.73 KB (0%) 2.1 s (0%) 6.5 s (-15.77% 🔽) 8.5 s
thirdweb (minimal + tree-shaking) 4.84 KB (0%) 97 ms (0%) 361 ms (+57.89% 🔺) 457 ms
thirdweb/chains (tree-shaking) 498 B (0%) 10 ms (0%) 49 ms (+26.01% 🔺) 59 ms
thirdweb/react (minimal + tree-shaking) 17.34 KB (0%) 347 ms (0%) 414 ms (+14.7% 🔺) 761 ms

@codecov
Copy link

codecov bot commented Oct 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 45.30%. Comparing base (83a2412) to head (7aab5ca).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5051   +/-   ##
=======================================
  Coverage   45.30%   45.30%           
=======================================
  Files        1067     1067           
  Lines       55304    55304           
  Branches     3970     3970           
=======================================
  Hits        25054    25054           
  Misses      29557    29557           
  Partials      693      693           
Flag Coverage Δ *Carryforward flag
legacy_packages 65.68% <ø> (ø) Carriedforward from 83a2412
packages 40.31% <ø> (ø)

*This pull request uses carry forward flags. Click here to find out more.

## Problem solved

Short description of the bug fixed or feature added

<!-- start pr-codex -->

---

## PR-Codex overview
This PR introduces a new `ModuleCard` component and its associated storybook entries, enhancing the UI for displaying module information in a dashboard. It also refactors the `InstalledModulesTable` to utilize the new `ModuleCard` component for better modularity and readability.

### Detailed summary
- Added `ModuleCard` component in `module-card.tsx`.
- Created storybook entries for `ModuleCard` in `module-card.stories.tsx`.
- Refactored `InstalledModulesTable` to render `ModuleCard` instead of a table.
- Removed unused skeleton and row components from `InstalledModulesTable`.

> ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}`

<!-- end pr-codex -->
@graphite-app
Copy link
Contributor

graphite-app bot commented Oct 28, 2024

Merge activity

@graphite-app graphite-app bot merged commit 7aab5ca into main Oct 28, 2024
30 checks passed
@graphite-app graphite-app bot deleted the modules-UI branch October 28, 2024 14:32
@vercel vercel bot temporarily deployed to Production – thirdweb_playground October 28, 2024 14:32 Inactive
@vercel vercel bot temporarily deployed to Production – docs-v2 October 28, 2024 14:32 Inactive
@vercel vercel bot temporarily deployed to Production – wallet-ui October 28, 2024 14:32 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Dashboard Involves changes to the Dashboard.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants